[FEAT] Refactors Page service to support nested routes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
feat/nested-navigation
branch
from
c8cb47e
to
06e5669
Compare
|
Note that this is technically a breaking change, since there will never be a |
pzuraq
force-pushed
the
feat/nested-navigation
branch
from
06e5669
to
3127f6f
Compare
This PR refactors the page service to allow it to support nested routes. The guiding principle here is that our UX for traversing the guides is a depth-first traversal of the docs tree, so rather than traversing the tree directly each time, we do a single traversal once, creating both a convenient data structure for looking up pages based on URL, and setting up the next/prev links between each page. Should likely add some tests around the `nextPage` and `previousPage` and their sections as well, to ensure that next/prev page work with arbitrary navigation trees.
pzuraq
force-pushed
the
feat/nested-navigation
branch
from
3127f6f
to
7a34157
Compare
MelSumner
approved these changes
Sep 24, 2019
|
So it looks like this has actually broken something 🙈 I notice on the deploy preview https://deploy-preview-21--guidemaker.netlify.com/release/ it shows the next page but when you click it then the previous page doesn't show up 🤔 it's something that we might need to back out and re-open the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the page service to allow it to support nested routes.
The guiding principle here is that our UX for traversing the guides is
a depth-first traversal of the docs tree, so rather than traversing the
tree directly each time, we do a single traversal once, creating both a
convenient data structure for looking up pages based on URL, and setting
up the next/prev links between each page.
Should likely add some tests around the
nextPageandpreviousPageand their sections as well, to ensure that next/prev page work with
arbitrary navigation trees.