Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Error: certificate has expired #723

Closed
nowherex opened this issue Oct 5, 2021 · 7 comments
Closed

[Bug] Error: certificate has expired #723

nowherex opened this issue Oct 5, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@nowherex
Copy link

nowherex commented Oct 5, 2021

Hi everyone, I recently started getting the following error: "Error: certificate has expired", but my certificate is not expired, I even renewed it (letsencrypt) and the error persisted, tested it on another mqtt broker (hivemq.com) and got the same mistake.

is there anything that can be done? I would very much like to continue using this fantastic tool, as I also use the emqx broker, thank you.

Environment

  • OS: Linux Mint
  • MQTTX version, Version: v1.6.0 and Version: v1.6.1

More detail

screenshot:

Mqttx Error

@nowherex nowherex added the bug Something isn't working label Oct 5, 2021
@oceanlvr
Copy link
Contributor

oceanlvr commented Oct 5, 2021

I'm not sure if this is a repeat of #721. Could you please test it on an older version, like v1.3.0?
Maybe you could post a reproduce detail.

Thanks for your feedback!

@oceanlvr oceanlvr self-assigned this Oct 5, 2021
@ysfscream ysfscream added this to Done in MQTTX Project Oct 9, 2021
@ysfscream ysfscream moved this from Done to To Do in MQTTX Project Oct 9, 2021
@bodiroga
Copy link

Hi @oceanlvr and @nowherex!

Could this problem be related to: electron/electron#31212? I'm seeing the same error connecting to my own MQTT broker (Mosquitto behind Traefik with a valid Let's Encrypt certificate) and the same happens to the "MQTT Explorer" client, which is also build with Electron. In fact, I came to your client after seeing that "MQTT Explorer" was failing and the truth is that I am thinking of migrating, because your UI is excellent.

What version of Electron are you using? They seem to have released patch releases for Electron 12, 13, 14, 15 and 16.

Thank for your help and best regards,

Aitor

@oceanlvr
Copy link
Contributor

@bodiroga @nowherex Thanks for your support, I'm tracking this problem.

What version of Electron are you using? They seem to have released patch releases for Electron 12, 13, 14, 15 and 16.

https://github.com/electron/electron/pulls?q=Root+CA+X3

https://releases.electronjs.org/

MQTT X's electron version is 11, and it seems that the electron team doesn't patch for the 11 version.

I'll reproduce the issue and determine that this problem is caused. If possible could you please help us test this problem?

I think you could upgrade the electron to the 12~16 latest patch version on the master branch.

@bodiroga
Copy link

Hi @oceanlvr!

Ok, good news, here you have what I have done and the results I got:

  • Clone the repo (master branch).
  • Install yarn and electron-builder (I didn't have them installed). I have to note that the "node --version" command prints that I'm working with the 15.4.0 version, not v14...
  • Edit the package.json file and modify the "electron" dependency to version 12.2.2.
  • Execute the "yarn install" command to install all dependencies.
  • Execute the "yarn run electron:serve" command to launch the app.

After that, I tried to connect to my MQTT broker (Mosquitto behind a Traefik proxy with a valid SSL certificate) and... it worked! 🎉 Awesome! But... I don't know if upgrading to Electron 12.* will have any side effect consequence, although in my fast tests I didn't notice any error. Subscribing to # and publishing some messages worked fine 😉

I hope this information can be of any help to you 👍🏻

Thanks again for all your work and best regards,

Aitor

@oceanlvr
Copy link
Contributor

oceanlvr commented Oct 15, 2021

@bodiroga good job! Very happy to receive your feedback, 🎉 🎉 🎉

Because upgrading to the new electron version is a free change, I may need more testing to officially push to release, thanks for your work! 👍🏻 👍🏻 👍🏻

@oceanlvr
Copy link
Contributor

@bodiroga Hi! I have been tested this upgrade, version 12.2.2 works for me.
We are delighted that you are a contributor to MQTT X, so could you please PR to the master branch? I am very happy to receive your contribution!
Thank you so much for your help and feedback!!!

@ysfscream
Copy link
Member

Thank you all. This issue is fixed on https://github.com/emqx/MQTTX/releases/tag/v1.7.0

@ysfscream ysfscream moved this from To Do to Done in MQTTX Project Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants