Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support to set annotations on the generated Service #116

Closed
ammmze opened this issue Feb 17, 2022 · 1 comment · Fixed by #126
Closed

[Feature Request] Add support to set annotations on the generated Service #116

ammmze opened this issue Feb 17, 2022 · 1 comment · Fixed by #126
Labels
enhancement New feature or request

Comments

@ammmze
Copy link

ammmze commented Feb 17, 2022

Is your feature request related to a problem? Please describe.
I'd like to be able to add an annotation to the Service that the EmqxBroker generates such as: coredns.io/hostname: "mqtt.example.com". This annotation specifically in my case causes coredns to add a DNS record resolving mqtt.example.com. to the ip address of the service.

Describe the solution you'd like
I think the spec.emqxTemplate.listener object on the EmqxBroker should support an annotations field which would then be used when generating the Service around here.

Describe alternatives you've considered
Alternatives would require that my load balancer ip is static and then manually adding the DNS record to core dns.
Or manually crafting a custom Service to run side by side with the one produced by the operator and effectively just leave the generated Service un-used.

@ammmze ammmze added the enhancement New feature or request label Feb 17, 2022
@Rory-Z
Copy link
Member

Rory-Z commented Feb 18, 2022

@ammmze
Cool !we will include this in our development plans

@Rory-Z Rory-Z linked a pull request Feb 23, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants