Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(banned): ensure the default expiration time of banned is large enough #9599

Merged
merged 1 commit into from Dec 27, 2022
Merged

fix(banned): ensure the default expiration time of banned is large enough #9599

merged 1 commit into from Dec 27, 2022

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Dec 22, 2022 •
edited

fix EMQX-8460

@lafirest lafirest changed the title fix(banned): ensure the default timeout of banned is large enough fix(banned): ensure the default expiration time of banned is large enough Dec 22, 2022
@coveralls
Copy link
Collaborator

coveralls commented Dec 22, 2022 •
edited

Pull Request Test Coverage Report for Build 3778549185

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 33 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.004%) to 79.567%
Files with Coverage Reduction New Missed Lines %
apps/emqx_authn/src/emqx_authn.erl 1 76.67%
apps/emqx_management/src/emqx_mgmt_api_trace.erl 1 86.49%
apps/emqx/src/emqx_alarm_handler.erl 1 50.0%
apps/emqx/src/emqx_authentication_config.erl 1 83.62%
apps/emqx/src/emqx_channel.erl 1 87.17%
apps/emqx/src/emqx_flapping.erl 1 85.11%
apps/emqx/src/emqx_os_mon.erl 1 84.06%
apps/emqx/src/emqx_session.erl 1 87.6%
apps/emqx/src/emqx_ws_connection.erl 1 79.28%
apps/emqx/src/emqx_banned.erl 2 90.91%
Totals Coverage Status
Change from base Build 3766676825: -0.004%
Covered Lines: 22546
Relevant Lines: 28336
💛 - Coveralls

@lafirest lafirest marked this pull request as ready for review December 22, 2022 13:28
thalesmg
thalesmg previously approved these changes Dec 22, 2022
View reviewed changes
apps/emqx/src/emqx_banned.erl Show resolved Hide resolved
@lafirest lafirest merged commit 2ff6ef0 into emqx:master Dec 27, 2022
@lafirest lafirest deleted the fix/blacklist_default_exp branch December 27, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone approved these changes

@thalesmg thalesmg thalesmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lafirest @coveralls @zmstone @thalesmg