Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rule engine http api (get/delete). #1381

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Update rule engine http api (get/delete). #1381

merged 3 commits into from
Jul 14, 2023

Conversation

xinyi-xs
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14 ⚠️

Comparison is base (fba26c1) 39.85% compared to head (3fec02c) 39.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
- Coverage   39.85%   39.71%   -0.14%     
==========================================
  Files          16       16              
  Lines        5114     5131      +17     
==========================================
  Hits         2038     2038              
- Misses       3076     3093      +17     
Impacted Files Coverage Δ
nanomq/rest_api.c 46.81% <0.00%> (-0.55%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

uint32_t id = 0;
cJSON *res_obj = NULL;
cJSON *data = NULL;
uint32_t id = 0;

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable id is not used.
cJSON *data = NULL;
uint32_t id = 0;
cJSON *res_obj = NULL;
cJSON *data = NULL;

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable data is not used.
}

static void
get_rules_helper(cJSON *data, rule *r)

Check notice

Code scanning / CodeQL

Unused static function Note

Static function get_rules_helper is unreachable
Comment on lines +2112 to +2114
// cJSON *meta = cJSON_CreateObject();
// cJSON_AddItemToObject(res_obj, "meta", meta);
// TODO add meta content: page, limit, count

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@JaylinYu JaylinYu merged commit 3115144 into master Jul 14, 2023
87 of 89 checks passed
@JaylinYu JaylinYu deleted the lee/rule branch July 14, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants