accept_stream hangs when connection dies

[klacke]

If client end dies, accept_stream hangs with a {quic, closed, Conn} message in the message queue.
A possible fix is:

accept_stream(Conn, Opts, Timeout) when is_list(Opts) ->
  accept_stream(Conn, maps:from_list(Opts), Timeout);
accept_stream(Conn, Opts, Timeout) when is_map(Opts) ->
  % @todo make_ref
  % @todo error handling
  NewOpts = maps:merge(default_stream_opts(), Opts),
  case quicer_nif:async_accept_stream(Conn, NewOpts) of
    {ok, Conn} ->
      receive
        {quic, new_stream, Stream} ->
          {ok, Stream};
        {quic, closed, Conn} ->
          {error, connection_closed}

      after Timeout ->
          {error, timeout}
      end;
    {error, _} = E ->
      E
  end.

[qzhuyan]

thanks for reporting.

Your solution will help if caller process is the owner of both connection and the stream so it will recv 'events' from both connection and stream.

I think we need a signal to inform the stream acceptor that the connection is closed in resource dtor.

something like the todo in https://github.com/emqx/quic/blob/main/c_src/quicer_nif.c#L639