Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] https://github.com/emre/unicode_tr/issues/8 #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yibudak
Copy link

@yibudak yibudak commented Oct 17, 2022

Bug 1:

Check #8

Bug 2:

title() method doesn't work properly.

from unicode_tr import unicode_tr
text = unicode_tr("ZEYNET MAH (BÜKARDI BELDESİ)")
text.title()
'Zeynet Mah (bükardı Beldesi)'

The result should be: 'Zeynet Mah (Bükardı Beldesi)'. It's fixed now.

At the same time, it would be better for compatibility to have all returns in the unicode_tr class since it's already inherited unicode or str types.

Tests

Python3:
Ran 5 tests in 0.001s

OK

Python2:
Ran 5 tests in 0.000s

OK

@yibudak
Copy link
Author

yibudak commented Mar 7, 2023

@emre any chance to merge? thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant