Kotlin library #12
Merged
Kotlin library #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrekose26
requested changes
Oct 5, 2018
There was a problem hiding this comment.
Thanks, @AndresMx35. But there are some things that should change.
- You should
.gradleand.ideafolders. That folders are unnecessary. - Also, you should change the package name. Project package name is not the same as my package name that you have added parts. You must change
com.anadromo.kotlin_recordbutton_libtocom.emrekose.kotlin_recordbutton_lib
|
Ok, let me fix it. |
Create package for kotlin classes on original lib
|
I think it's ok already based on your last review. Can you review it? |
|
Thanks @AndresMx35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I just pass your RecordButton library to Kotlin and add an example on your package. What do you think?