Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize fails with json.decoder.JSONDecodeError: Expecting ',' delimiter #14387

Open
KeyboardDanni opened this issue Jun 6, 2021 · 3 comments

Comments

@KeyboardDanni
Copy link

KeyboardDanni commented Jun 6, 2021

I can't seem to compile my Rust-based application on the latest emscripten (tried 2.0.23 and 2.0.22). Seems like wasm-emscripten-finalize is spitting out invalid JSON:

json.decoder.JSONDecodeError: Expecting ',' delimiter: line 30 column 22 (char 9178)

The bad line appears to be here, where unescaped quote marks are being inserted:

"__invoke_void_%"std::vec::Vec<std::boxed::Box<dynkeeshond::scene::Component>>"*",

I'm assuming that wasm-emscripten-finalize would just need to look for quote marks in these names and replace them with \"? Or should the quote marks not be there at all?

Full error log attached.
emscripten_error.txt

@KeyboardDanni
Copy link
Author

Did some more testing and it seems that emscripten 2.0.6 is the last working version.

This is with rustc 1.51.0 stable if it's relevant.

@sbc100
Copy link
Collaborator

sbc100 commented Jun 7, 2021

This is an issue the version of clang/llvm being too old.

@tlively what is the recommended path for rustc users here?

@KeyboardDanni
Copy link
Author

After upgrading my version of rustc, it seems like this is resolved. I can't switch to latest emscripten yet due to #14313 but seems like 2.0.13 works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants