Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In -sMODULARIZE mode the moduleArg should not be modified in place #21648

Open
sbc100 opened this issue Mar 28, 2024 · 0 comments
Open

In -sMODULARIZE mode the moduleArg should not be modified in place #21648

sbc100 opened this issue Mar 28, 2024 · 0 comments

Comments

@sbc100
Copy link
Collaborator

sbc100 commented Mar 28, 2024

Right now you can observe the new module object propertires before the module promise resolves, breaking the encapsulation.

I tried to avoid this in the past but its make very hard due the way fact that we return moduleArg at the end of the generated code and returning anything else is tricky when building with --closure=1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant