Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gated out #include directives in JS libraries are still included #5458

Closed
juj opened this issue Aug 10, 2017 · 4 comments
Closed

Gated out #include directives in JS libraries are still included #5458

juj opened this issue Aug 10, 2017 · 4 comments

Comments

@juj
Copy link
Collaborator

juj commented Aug 10, 2017

liba.js

#if 0
#include "libnonexisting.js"
#include "libb.js"
#endif

libb.js

syntax error here

Command line: emcc tests/hello_world.c --js-library liba.js -o a.html

Should be valid and build without errors, but currently fails with

Error: ENOENT: no such file or directory, open 'C:\code\emsdk\emscripten\incoming\src\libnonexisting.js'
@marcmoo
Copy link

marcmoo commented Sep 20, 2018

same issue

@stale
Copy link

stale bot commented Sep 20, 2019

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Sep 20, 2019
@sbc100
Copy link
Collaborator

sbc100 commented Sep 20, 2019

Lets see if this is still an issue..

@stale stale bot removed the wontfix label Sep 20, 2019
@sbc100
Copy link
Collaborator

sbc100 commented Sep 20, 2019

Looks like its fixed.

@sbc100 sbc100 closed this as completed Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants