Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running on Python 3? #5950

Closed
saschanaz opened this issue Dec 19, 2017 · 6 comments
Closed

Allow running on Python 3? #5950

saschanaz opened this issue Dec 19, 2017 · 6 comments

Comments

@saschanaz
Copy link
Collaborator

saschanaz commented Dec 19, 2017

Now we have all PRs merged to pass CI with Py3 (except #5946), we now can allow Py3 rather than forcing Py2. What do you think?

We currently have two CIs running, so we may let one to run Py2 and the other to run Py3.

@saschanaz saschanaz changed the title Allow running by Python 3? Allow running on Python 3? Dec 19, 2017
@kripken
Copy link
Member

kripken commented Dec 19, 2017

Yeah, we should move forward here. How about allowing Py3, but showing a warning when it is used, "this is experimental" or such?

Good idea about making one CI use 2, and the other 3. That can help a lot until we can move entirely to Py3.

@kripken
Copy link
Member

kripken commented Dec 19, 2017

Maybe it should even be a flag, emcc --python3? That might be excessive though.

@saschanaz
Copy link
Collaborator Author

saschanaz commented Dec 20, 2017

Yeah, we should move forward here. How about allowing Py3, but showing a warning when it is used, "this is experimental" or such?

👍

Maybe it should even be a flag, emcc --python3? That might be excessive though.

That way every test should add the flag, which is not preferable in my opinion. We may add a EMCC_OPTIONS environment variable and use EMCC_OPTIONS=--python3 to reduce diffs (like NODE_OPTIONS do)

@juj
Copy link
Collaborator

juj commented Dec 20, 2017

I think I should work on getting Emsdk to bundle up Python 3 as an optional package as well, so that we can get Windows users optionally over to Python 3 when possible, to get people to test this out. I think once things are solid, we could even look at dropping Python 2 support, since Python community seems to be aggressive about it.

This is assuming that Python 3 has at least equally good Windows support, whereas Python 2 Windows was quite buggy for a long time in piping and multiprocessing support, causing some quite annoying workarounds.

@juj
Copy link
Collaborator

juj commented Dec 20, 2017

https://pythonclock.org is an interesting site.

@saschanaz
Copy link
Collaborator Author

saschanaz commented Jan 18, 2018

Fixed by #5967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants