New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need a better way to handle node.js + pthreads errors #9899
Comments
cc @addaleax |
This is what I would do too 👍 If you do want an alternative, it would be |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
With the changes made in #9863 errors in a node.js pthread are reported like
pthread sent an error! undefined:undefined: Module is not a function
.This could be more helpful, it would be good to get a line number and file like we do in the web case. At a minimum
undefined:undefined
should go.My suggestion would be to replace
emscripten/src/library_pthread.js
Line 441 in 408a6e9
with
err('pthread sent an error!\n' + data.stack);
. This will print out something like:This is slightly more helpful. However I'm not familiar enough with node to know if there's something better.
Anyone have any better ideas?
The text was updated successfully, but these errors were encountered: