Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore npm install step removed in #1325 #1329

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Restore npm install step removed in #1325 #1329

merged 1 commit into from
Jan 3, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jan 3, 2024

No description provided.

@sbc100 sbc100 requested a review from kripken January 3, 2024 17:38
@sbc100 sbc100 enabled auto-merge (squash) January 3, 2024 17:38
kripken
kripken approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have tests for this?

@sbc100 sbc100 merged commit 0bbae74 into main Jan 3, 2024
10 checks passed
@sbc100 sbc100 deleted the npm_install branch January 3, 2024 18:25
@sbc100
Copy link
Collaborator Author

sbc100 commented Jan 3, 2024

Do we not have tests for this?

I guess not.. I'm not even sure these install targets are even still supported at all. I will followup and see if we can remove them maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbc100 @kripken