Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only pass -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON when building llvm. NFC #1334

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Only pass -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON when building llvm. NFC #1334

merged 1 commit into from
Jan 24, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jan 24, 2024

No description provided.

@sbc100 sbc100 requested review from juj and dschuff January 24, 2024 18:23
dschuff
dschuff approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but is this still needed? LLVM has required a C++17 toolchain for a long time, and I would be surprised if it builds with a really old toolchain

@sbc100
Copy link
Collaborator Author

sbc100 commented Jan 24, 2024

LGTM but is this still needed? LLVM has required a C++17 toolchain for a long time, and I would be surprised if it builds with a really old toolchain

I don't use this code path enough to know.. so for now I'll just land this as is.

@sbc100 sbc100 merged commit f2baa2f into main Jan 24, 2024
10 checks passed
@sbc100 sbc100 deleted the llvm_cmake_flag branch January 24, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

@juj juj Awaiting requested review from juj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbc100 @dschuff