Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build latest docker image rather than tot #1359

Merged
merged 1 commit into from
Mar 14, 2024
Merged

CI: Build latest docker image rather than tot #1359

merged 1 commit into from
Mar 14, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 14, 2024

This means that CI run that update latest actually test the thing we are about to ship.

We recently had a case where latest was broken but tot was fixes and we accidentally shipped a broken SDK version (#1353).

@sbc100 sbc100 requested review from kripken and aheejin March 14, 2024 16:11
@sbc100
Copy link
Collaborator Author

sbc100 commented Mar 14, 2024

I expect the CI for this to fail because latest is currently broken, however I think we should land this anyway so that when we update latest we can see that it gets fixed.

This means that CI run that update `latest` actually test the thing
we are about to ship.

We recently had a case where `latest` was broken but `tot` was fixes
and we accidentally shipped a broken SDK version (#1353).
@sbc100 sbc100 merged commit 44bf7cf into main Mar 14, 2024
9 of 10 checks passed
@sbc100 sbc100 deleted the docker_latest branch March 14, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants