Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geos #1128

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Add Geos #1128

merged 6 commits into from
Jun 20, 2024

Conversation

KGB99
Copy link
Contributor

@KGB99 KGB99 commented Jun 18, 2024

No description provided.

@KGB99
Copy link
Contributor Author

KGB99 commented Jun 18, 2024

This seems to be a longer existing problem in emscripten:
emscripten-core/emscripten#22005
emscripten-core/emscripten#11087
Keno/julia-wasm#27

If cmake is executed with -DBUILD_TESTING=OFF the build seems to succeed, however im not sure how wise it is to ignore all tests.

@wolfv
Copy link
Contributor

wolfv commented Jun 19, 2024

Maybe you can find another way to test this? Or remove tests that make the build fail?

@KGB99
Copy link
Contributor Author

KGB99 commented Jun 19, 2024

I started working on a patch where i just remove the tests that fail. Should be working soon hopefully :)

@wolfv
Copy link
Contributor

wolfv commented Jun 19, 2024

Looks good to me although I couldn't really see if the tests are executed or not.

@KGB99
Copy link
Contributor Author

KGB99 commented Jun 20, 2024

The tests indeed did not run before. I tried a lot of things in the recipe such as:

tests:
  - script:
      - node bin/test_geos_unit.js
    requirements:
      build:
        - nodejs
    files:
      source:
        - tests/
        - bin/test_geos_unit.js 

However I constantly get file not found errors regarding bin/test_geos_unit.js. I think there is something im not understanding right.
I will add some existence tests for now.

@wolfv
Copy link
Contributor

wolfv commented Jun 20, 2024

Hey @KGB99 - that's because the tests are not installed into the final package. You would have to execute them as part of your build script.

You might be able to invoke them with CMake / ctest.

@KGB99 KGB99 mentioned this pull request Jun 20, 2024
@KGB99 KGB99 marked this pull request as ready for review June 20, 2024 11:37
@IsabelParedes IsabelParedes merged commit 02ea552 into emscripten-forge:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants