Skip to content
This repository has been archived by the owner on Feb 17, 2022. It is now read-only.

Feed silence to device when paused #140

Merged
merged 1 commit into from Mar 31, 2021
Merged

Feed silence to device when paused #140

merged 1 commit into from Mar 31, 2021

Conversation

Daft-Freak
Copy link
Member

Otherwise Chrome loops the old buffer contents.
Fixes #69.

kripken
kripken approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know if this is correct behavior in chrome or not? (Can file a bug if we are not sure.)

@Daft-Freak
Copy link
Member Author

Hmm, I'd guess that doing nothing in onaudioprocess isn't a valid thing to do? (Seems to result in silence in Firefox though instead of old data)

@Daft-Freak Daft-Freak merged commit edfa580 into master Mar 31, 2021
@Daft-Freak Daft-Freak deleted the audio-pause-silence branch March 31, 2021 10:23
@kripken
Copy link
Member

kripken commented Mar 31, 2021

Could be, good point. Reading the docs I'm not sure. But the entire API is marked as deprecated, so it's probably not worth looking into more...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pausing/closing audio repeats the buffer in Chromium indefinitely
2 participants
@Daft-Freak @kripken