Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize WebUI rendering when using Dialog Boxes #1116

Closed
proddy opened this issue Mar 12, 2023 · 3 comments
Closed

Optimize WebUI rendering when using Dialog Boxes #1116

proddy opened this issue Mar 12, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request technical Technical enhancement, or tech-debt issue
Milestone

Comments

@proddy
Copy link
Contributor

proddy commented Mar 12, 2023

When a Dialog (Modal) is open in the WebUI (e.g. editing an entity, renaming a customization) the whole screen is still refreshed which is slow and inefficient. It's because of how React renders the nested children in the DOM due to the state changes. The correct way is to enclose the state changes in a separate React component.

https://www.developerway.com/posts/react-re-renders-guide

@proddy proddy self-assigned this Mar 12, 2023
@proddy proddy added enhancement New feature or request technical Technical enhancement, or tech-debt issue labels Mar 12, 2023
@proddy proddy added this to the v3.6.0 milestone Mar 12, 2023
@proddy proddy changed the title Optimize WebUI rendering with Modals Optimize WebUI rendering when using Dialog Boxes Mar 13, 2023
@proddy
Copy link
Contributor Author

proddy commented Apr 22, 2023

dialogs in the settings pages done in 3.6.0-dev10

The modal dialog pop-ups in Settings Customization/Entities/Scheduler no longer cause the parent to re-render which improves performance.

Next to do is the DashboardData

@proddy
Copy link
Contributor Author

proddy commented Apr 28, 2023

Whilst working on this I moved Sensors (Temperature & Analog) to it's own tab, so not in DeviceData anymore. It makes it easier to navigate and the code is much cleaner.

and...I renamed dallas to temperature also in the C code to be consistent with the front-end

@proddy
Copy link
Contributor Author

proddy commented May 25, 2023

in dev11

@proddy proddy closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request technical Technical enhancement, or tech-debt issue
Projects
None yet
Development

No branches or pull requests

1 participant