Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exhaust temperature always zero on GB125/MC110/RC310 #1147

Closed
minusdreidb opened this issue Mar 26, 2023 · 6 comments
Closed

Exhaust temperature always zero on GB125/MC110/RC310 #1147

minusdreidb opened this issue Mar 26, 2023 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@minusdreidb
Copy link
Contributor

minusdreidb commented Mar 26, 2023

Hi,

I noticed that the exhaust gas temperature reported by EMS-ESP32 is always zero on my system while the RC310 shows the actual value. Th3M3 notes (https://github.com/Th3M3/buderus_ems-wiki/blob/master/Quelle_08.md) align with the data I found on my system and I implemented a now tested fix which can be found here: minusdreidb@982a43b.

The location at offset 6 in telegram 0xE5 is always zero on my system causing the initial problem, therefore I commented it out.
I don't have telegram 0x19 which also seems to carry the exhaust temp. according to boiler.cpp.

What is the right strategy to handle this situation (assuming that offset 6 in 0xE5 is a known good location for the exhaust temperature and not a bug)?

My system setup including SW-Versions is documented in the above linked commit's message.

@proddy
Copy link
Contributor

proddy commented Mar 26, 2023

What do you think @MichaelDvP ? Just remove the ExhaustTemp from 0xE5/UBAMonitorSlowPlus for everyone?

@MichaelDvP
Copy link
Contributor

The e5 offset 6 was just a guess from emsesp/EMS-ESP#620 (comment) becauseof fast changing temperaturerise after burner start.
@minusdreidb If you can verify that e4 offset 31 is the exhaust temp, make a PR.
But in the old thread e4 offset 31 was always zero. Maybe read both and take the nonzero value?

@proddy
Copy link
Contributor

proddy commented Mar 26, 2023

also note its a short 2-byte so you make sure the value at offset 6 and 7 are both zero

@minusdreidb
Copy link
Contributor Author

@minusdreidb If you can verify that e4 offset 31 is the exhaust temp, make a PR. But in the old thread e4 offset 31 was always zero. Maybe read both and take the nonzero value?

@MichaelDvP I verified the location against the diagnostics reading for the exhaust temp. on my RC310.

But in the old thread e4 offset 31 was always zero. Maybe read both and take the nonzero value?

This is something that should be handled in a consistent manner by has_update() in my opinion.

also note its a short 2-byte so you make sure the value at offset 6 and 7 are both zero

@proddy Sorry, I don't understand your comment. Does has_update() not read only 2 bytes for exhaustTemp_?

@proddy
Copy link
Contributor

proddy commented Mar 27, 2023

@proddy Sorry, I don't understand your comment. Does has_update() not read only 2 bytes for exhaustTemp_?

I think exhaustTemp_ is a uint16_t which means it's two bytes long, starting at offset 6. So zero is 0x0000

@minusdreidb
Copy link
Contributor Author

Ok, got it. You meant for testing the "raw" bytes in 0xE5 and conditionally calling has_update().

minusdreidb added a commit to minusdreidb/EMS-ESP32 that referenced this issue Apr 1, 2023
proddy added a commit that referenced this issue Apr 2, 2023
Fix #1147 - Exhaust temperature always zero on GB125/MC110/RC310
@proddy proddy added this to the v3.6.0 milestone Jul 3, 2023
@proddy proddy added the bug Something isn't working label Jul 3, 2023
@proddy proddy closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants