Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribed MQTT topics not detecting changes by EMS-ESP #1494

Closed
proddy opened this issue Dec 11, 2023 · 2 comments
Closed

Subscribed MQTT topics not detecting changes by EMS-ESP #1494

proddy opened this issue Dec 11, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@proddy
Copy link
Contributor

proddy commented Dec 11, 2023

Found some peculiar behaviour with MQTT and I'm not sure what is causing it.

EMS-ESP is correctly subscribing to the topic ems-esp/thermostat/# as shown in the Mosquitto verbose logs. But when I publish to ems-esp/thermostat/hc1/seltemp it does not get picked up by EMS-ESP.

I thought at first something with the base/basename change I did, but that looks ok. For some reason, the callback onMessage(callback) is not triggered.

@MichaelDvP have you seen this before?

@MichaelDvP
Copy link
Contributor

No, have not realized it before, my esp32 with dev.2 (2.12.23) is working good. The S3 with actual software do not call onMessage.
Don't know what it is, made some tests. If i register a callback within MqttSettingsService and call mqtt::onMessage from there (like onMqttConnect, onMqttDisconnect), it works and structure is more clear. I'll make a PR.

@proddy
Copy link
Contributor Author

proddy commented Dec 12, 2023

I can confirm this fixes the issue, I'll add to my PR and push to dev. Thanks @MichaelDvP

@proddy proddy closed this as completed Dec 12, 2023
@proddy proddy added the bug Something isn't working label Dec 12, 2023
@proddy proddy added this to the v3.6.5 milestone Dec 12, 2023
proddy added a commit to proddy/EMS-ESP32 that referenced this issue Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants