Progress bar on upload

[MichaelDvP]

In the latest 3.6.4-dev9 the upload progress starts with 350% and counts down to 100%, the bar runs from right to left showing the range 200% - 100%. Only cosmetic, no functioal issue. I have not found a change that causes this. Maybe a updated package?

[proddy]

hmm, not sure which package but I'll check.

[MichaelDvP]

Seems the progress.total and progress.loaded are mixed. Tried to go back to alova 2.16.2, but no luck. I've made a workaround and check what value is greater to calculate the percentage. This works in my tests, but it's better to fix the root cause.

[proddy]

thanks, I'll investigate and try and find what has changed. the workaround is perfect for the time being

[proddy]

I'm still seeing this error, now and then. I'll re-open and spend some time fixing it. the latest alova lib now exposes event listeners to the upload progress

[MichaelDvP]

I'm still seeing this error, now and then

I think this is due to the cache setting you've added a few days ago. I've commented it out for me, because i often change the versions and get confsed if changes don't show up.

[proddy]

good point, will look into that and rollback

[proddy]

I've removed the cache, will be in next PR. Let's see if it resolves the issue.

[proddy]

I added an etag for better cache management. But this issue with the progress bar is still there, on Mac OSX (edge) so I need to look into the Alova code again.

[MichaelDvP]

After updating to alova 2.20.0 the progressbar is not shown anymore.

[proddy]

I'll fix

[proddy]

I've logged an issue with the Alova team

EDIT: it worked in alova 2.19.2

[proddy]

Alova team have a fix, waiting for the next release.

[MichaelDvP]

v2.20.2 is out and working.
But still loaded and total are exchanged. The percentage is only shown right for (total * 100) / loaded.

[proddy]

I'll test as well

[proddy]

looks ok to me, I see the progress go from 0 to 100? What am I missing?

[MichaelDvP]

The fix for the wrong direction was this check (same for the % number):

EMS-ESP32/interface/src/components/upload/SingleUpload.tsx

Lines 91 to 93 in 1487f30

	: progress.loaded <= progress.total
	? Math.round((progress.loaded * 100) / progress.total)
	: Math.round((progress.total * 100) / progress.loaded)

Works, but would be nice if names total and loaded match the meaning.

[proddy]

ah yes, I remember we had to hack that. I'll report it Alova.

[proddy]

I'll make a PR