Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit command "mode" not working #207

Closed
FredericMa opened this issue Nov 19, 2021 · 4 comments
Closed

Circuit command "mode" not working #207

FredericMa opened this issue Nov 19, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@FredericMa
Copy link

Bug description
I just upgraded to v3.3.0b8 (because of the MQTT reconnect issue I had before).
When I publish {"cmd":"mode" ,"data":"heat", "id":1} to the ems-esp/thermostat topic. The heating circuit its mode isn't changed.
I only see the following in the logs:

2021-11-19 12:11:00.111    INFO 80:     [command]    Calling thermostat command 'values', value cmd, id is default

This was working before. I guess I was on some 3.2.1 beta build.

Steps to reproduce
Publish {"cmd":"mode" ,"data":"heat", "id":1} to the ems-esp/thermostat topic.

Expected behavior
I expect the mode of circuit 1 to change to heat. Now it remains at nofrost

Device information
This API command to get the info doesn't seems to work anymore. I get this when browsing to http://192.168.xxx.xxx/api?device=system&cmd=info:

{
message: "missing command in path"
}

Nonetheless, I am using a Junkers FW200 thermostat.

@FredericMa FredericMa added the bug Something isn't working label Nov 19, 2021
@proddy
Copy link
Contributor

proddy commented Nov 19, 2021

yup, reproduced. working on a fix...

@proddy proddy self-assigned this Nov 19, 2021
@FredericMa
Copy link
Author

That's quick! Thanks!

@proddy
Copy link
Contributor

proddy commented Nov 19, 2021

It's because I switched the key from 'data` to 'value' but really both should be allowed for backwards compatibility as mentioned in https://emsesp.github.io/docs/#/Command?id=definitions

The firmware is building, it's still the same version (b8)

proddy added a commit to proddy/EMS-ESP32 that referenced this issue Nov 19, 2021
proddy added a commit that referenced this issue Nov 19, 2021
@proddy proddy closed this as completed Nov 19, 2021
@FredericMa
Copy link
Author

I can confirm that it works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants