Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make shower timer settings configurable #436

Closed
lbbrhzn opened this issue Apr 2, 2022 · 3 comments
Closed

make shower timer settings configurable #436

lbbrhzn opened this issue Apr 2, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@lbbrhzn
Copy link

lbbrhzn commented Apr 2, 2022

Is your feature request related to a problem? Please describe.
The settings for the shower timer are currently hardcoded. The max shower duration is fixed to 7 minutes.

Describe the solution you'd like
Make the max shower duration configurable through settings. Change the unit to seconds instead of ms.

Setting Description
SHOWER_PAUSE_TIME 15 seconds, max time if water is switched off & on during a shower
SHOWER_MIN_DURATION 2 minutes, before recognizing its a shower
SHOWER_OFFSET_TIME 5 seconds grace time, to calibrate actual time under the shower
SHOWER_COLDSHOT_DURATION 10 seconds for cold water before turning back hot water
SHOWER_MAX_DURATION 7 minutes, before trigger a shot of cold water

Describe alternatives you've considered
Forking the repo and changing the hardcoded constants.
Using an automation in home assistant.

@lbbrhzn lbbrhzn added the enhancement New feature or request label Apr 2, 2022
@proddy
Copy link
Contributor

proddy commented Apr 2, 2022

ok, wasn't sure if anyone actually used that feature! Do you just want the max duration (7 mins) to be configured?

@lbbrhzn
Copy link
Author

lbbrhzn commented Apr 2, 2022

yes! but adjusting the coldshot duration would also be nice.

@proddy proddy added this to the v3.4.1 milestone Apr 3, 2022
@proddy
Copy link
Contributor

proddy commented May 1, 2022

added in b15

@proddy proddy modified the milestones: v3.4.1, v3.4 May 1, 2022
@proddy proddy closed this as completed May 1, 2022
proddy added a commit to proddy/EMS-ESP32 that referenced this issue May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants