added "availability" section in HA Discovery #1077
Conversation
This will allow to not remove discovery topics during each ems-esp restart (MQTT init), so it can solve issue emsesp#910. After applying this fix (and removing from the code commands that delete discovery topics) HA no longer reports errors/warnings in the log. I'm testing if for over a week. Now it is enough to delete discovery topics only when it is really needed (e.g. the entity has been removed by customization, discovery prefix has been changed or the HA option has been disabled in the configuration).
|
err, hang on, this could be a solution to #1067 which we've been working on are you saying by introducing the discovery availability attribute we no longer need to clean up old HA discovery config topics when EMS-ESP starts? That's quite cool. |
|
could you merge this into the tech-upgrade branch? |
never mind, I've added it manually so I can test it. I'll report back here. |
|
merged with tech-upgrade branch |
|
Pls be good, this would be huge for me. |
It seems so. If no specific value exists in the topic Besides, all EMS-ESP entities become unavailable if topic It is only necessary(?) to ensure that in a situation where HA discovery is generated (at the start of EMS-ESP or when the user changes format in the EMS-ESP MQTT configuration), data topics do not have value inconsistent with previous discovery definition. In such situations, it would be the best(?) to delete |
This will allow to not remove discovery topics during each ems-esp restart (MQTT init), so it first step to solve issue #910.
After applying this fix (and removing from the code commands that delete discovery topics) HA no longer reports errors/warnings in the log. I'm testing if for over a week.
Now it is enough to delete discovery topics only when it is really needed (e.g. the entity has been removed by customization, discovery prefix has been changed or the HA option has been disabled in the configuration).