Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix console show with empty full name #404

Closed
wants to merge 1 commit into from
Closed

Conversation

MichaelDvP
Copy link
Contributor

But maybe the point: // 4. for MQTT we want to always show the special HA entities (they have an empty fullname)
is obsolete. We have only the climate entitiy, which is only needed to create the ha-config, a publish is not needed.
Then we can reduce to: bool visible = ((dv.has_state(DeviceValueState::DV_VISIBLE) && dv.full_name)

@proddy
Copy link
Contributor

proddy commented Mar 19, 2022

yes. makes sense.

Remind me, I do need to find some time to start on improving the customization feature to set flags for MQTT and read-only (#317).

@MichaelDvP
Copy link
Contributor Author

If you want to add the visibility-flags to 3.4 should we wait with this for the extra flags? It will get something like:

        bool conditions = ((tag_filter == DeviceValueTAG::TAG_NONE) || (tag_filter == dv.tag)) && dv.has_state(DeviceValueState::DV_ACTIVE) && dv.full_name;
        bool visible    = (dv.has_state(DeviceValueState::DV_MQTT) && (output_target == OUTPUT_TARGET::MQTT)) 
                       || (dv.has_state(DeviceValueState::DV_INFO) && (output_target == OUTPUT_TARGET::API_VERBOSE))
                       || (dv.has_state(DeviceValueState::DV_VALUE) && (output_target == OUTPUT_TARGET::API_SHORTNAME));

or as first step only remove the mqtt publish for fullname.empty?

@MichaelDvP MichaelDvP closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants