Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Moduline 400 WW settings and timer clock program #467

Merged
merged 11 commits into from
Apr 13, 2022

Conversation

kwertie01
Copy link
Contributor

In this PR I added new features for the Moduline 400 Thermostat.

I added 5 parameters of the 0x3A telegram from the Moduline 400 (RC30) thermostat. (RC30wwSettings)

  • wwmode
  • wwwhenmodeoff
  • wwdisinfect
  • wwdisinfectday
  • wwdisinfecthour

I added 7 parameters of the 0x40 telegram from the Moduline 400 (RC30) thermostat. (RC30Temp)

  • heatingtype
  • controlmode
  • nighttemp
  • daylowtemp
  • daymidtemp
  • daytemp
  • holidaytemp

Added reading/writing of the switch points (switchtime1) of the Moduline 400 (RC30) clock program (0x3F telegram) including the following parameters:

  • program
  • pause
  • party
  • vacation
  • holiday

Copy link
Contributor

@MichaelDvP MichaelDvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
While checking i've seen some old bugs: the RC20 also uses T1-T4, but masks wrong with & 1 when reading and set_switchtemp checks input to max 3 instead of 4. I 'll fix this later, or, if you like, you can add to this PR.

@kwertie01
Copy link
Contributor Author

I'm a little bit ashamed and must admit that I didn't test the set_switchtemp properly. You are right that this is not working correctly now. I can set it using a number <3 but not using the letter T in front and/or number 4.
I see indeed that the mask for RC20 is &1. (old bug)
I will change/fix this in this PR.

@proddy
Copy link
Contributor

proddy commented Apr 12, 2022

@MichaelDvP you can approve the Merge request if you're fine with the additions.

@kwertie01
Copy link
Contributor Author

@MichaelDvP The (old) bug of the RC20 mask and the set_switchtemp for the RC30 are fixed.

@MichaelDvP
Copy link
Contributor

Thanks, only one remark:
The RC20 also have T1-T4, please set in line 2501 max_on = 4, then you don't need the if for RC30. And you can set the RC20 text to FL_(nighttemp1) (line 3697) to make it perfect.

@kwertie01
Copy link
Contributor Author

I saw your remark too late and already created the disable usage of T0 for RC30 in set_switchtime commit.
In the second commit, I implemented your remarks.

Copy link
Contributor

@MichaelDvP MichaelDvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, @proddy: i don't have more remarks, please merge.

@proddy proddy merged commit fdefd02 into emsesp:dev Apr 13, 2022
@proddy
Copy link
Contributor

proddy commented Apr 13, 2022

done! nice work chaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants