Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Dependencies and Broken Tests #24

Open
aabdullah-bos opened this issue Sep 28, 2017 · 2 comments
Open

Missing Dependencies and Broken Tests #24

aabdullah-bos opened this issue Sep 28, 2017 · 2 comments

Comments

@aabdullah-bos
Copy link
Contributor

I forked prophet and then cloned my fork. I then tried to run the quickstart.py example, but it failed because pandas-datareader and seaborn were not installed, they were not installed, because they were not in setup.py file.

Also, the integration test for the quickstart failed, because the YahooData class dose not support cache_data. I fixed this on my fork by adding both cache_path and data_path to the init methods for:

  • YahooData
  • YahooCloseData
  • PandasDataGenerator

You can find my changes in the merge that I made to my fork...

aabdullah-bos#1

If this is what, you intended. I can submit a pull request to your fork.

@Emsu
Copy link
Owner

Emsu commented Oct 1, 2017

Feel free to submit a pull request @aabdullah-bos

@aabdullah-bos
Copy link
Contributor Author

I've submitted the PR #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants