-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dependancies and tests #26
Conversation
* Out of the box I was unable to run the quickstart.py example, because the setup.py did not require __pandas-datareader__ or __seaborn__.
* It looks like there was a change to the the generator interface that was intended, but not implemented. When I attempted to run tox I encountered the error: E TypeError: __init__() got an unexpected keyword argument 'cache_path' This was because the attempt to create an instance of the YahooData generator was passing cache_path, which was not in the parameter list for the class. I've added both cache_path and data_path as well as `__init__` methods for all generators so that they invoke the base class `__init__` method.
Import fix
* Forgot to include this as part of the update.
Missed edit
* The charting module improts seaborn, althought it doesn't use it. I am assuming that seaborn may be used in the future. Seaborn requires importlib, which is not part of the Python Standard Library in Python 2.6, so I am removing 2.6 from the travis file so that higher versions are installed. I could have gone with a conditional install, but it seemed like it was more trouble than it was worth. I could have also just removed the seaborn dependency, but since I am not the maintainer I will leave that decision to him. If the decision is made to remove the seaborn depencdency then support for Python 2.6 can be added back.
Updated travis config
@aabdullah-bos Looks good. 3.2 - 3.4 seem broken still. Is that something that's a quick fix on your end? If not happy to merge this in first since it cleans up tests for the most recent Python versions. |
@Emsu Yeah, I saw that. I think that the issue only has to do with the test, and not the code under test, so it should be safe to merge. There is something different about how relative imports are handled in Python 3.2, 3.3, and 3.4. I'll look into it and submit a separate fix so that all the test work. |
So, I tried running tox in a docker container for py3.2 and I got the following warning:
I then got error messages associated with my docker container not having Python 2.7 installed. Anyway, I then ran a Docker container with Python3.4 installed and the test passed:
So while, I'm still not sure the Python 3.4 test failed. You may want to consider dropping Python 3.2 and Python 3.3 from the test matrix, but that's a decision. I'll leave to you! |
* Since some python versions can't find prophet I am explictly setting the PYTHONPATH
Import fix
* Added line to skip missing interpreters
Not needed.
* The test infrastructure itself shouldn't need to specify the pandas version.
* I encountered a number of different issues attempting to run the tests for Python 3.2 and 3.3. It looks like the docker image being used for 3.2 is using pip 7.1.2 and has an issue with the syntax in install_requires section of the setup. It also looks like the testing of 3.3 has an issue with installing numpy. The error message ends with: ``` RuntimeError: Python version 2.7 or >= 3.4 required. ``` If others have concern you should investigate these issues further.
Added tox install
@Emsu I've made a few changes to both the travis and tox configurations. Below is a brief description of my rationale.
NOTE: You should probably add a deploy step to the travis configuration to build the sdist and wheels after the test run successfully for tag builds. I can help with that once you've got this commit merged. |
@Emsu Any thoughts on this pull request? |
@aabdullah-bos looks good. Sorry for the delay. |
This pull request adds pandas-datareader and seaborn to the dependency list in setup.py, since they are needed by the data module and the charting module.
When I ran tox I noticed that the integration test for the quickstart was failing because the interfaces for the Data Generator sub-classes had not been expanded to accept cahce_path and data_path values.
I'm not sure if you wanted to expose these as parameters to the API, but it seemed worthwhile. Anyway, this commit should fix any install problems as well as get the test to start passing.