Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0 support #33

Closed
devolf92 opened this issue Apr 21, 2022 · 28 comments
Closed

5.0 support #33

devolf92 opened this issue Apr 21, 2022 · 28 comments

Comments

@devolf92
Copy link

I'm really in love with this plugin! Thanks for a great job!
Recently Cura released 5.0 beta but looks like they brake something and plugin stopped to work. While loading Cura says that plugin need to be reinstalled

@LMS0815
Copy link

LMS0815 commented Apr 22, 2022

You can find addtitonal details at: https://community.ultimaker.com/topic/40288-ultimaker-cura-50-beta/

One major change is that the GUI framework Qt was updated from version 5 to version 6, to support newer operating systems (and fix multiple bugs with the previous version of Qt, which was no longer updated). Unfortunately this means that most of the UI of Cura and its plugins has to be made compatible with this newer version of Qt. Because of that all plugins need to be updated and resubmitted to the Marketplace.

@emtrax-ltd
Copy link
Owner

yo! big change but easy fix. Buuut... i will take this opportunity to do some code refactoring.

@PhilBaz
Copy link

PhilBaz commented Apr 22, 2022

@emtrax-ltd

Looking forward to it!!!

Yeah, all plug-ins need to be reworked so currently the plugin 'market place' is totally empty...

@emtrax-ltd
Copy link
Owner

OK... take a look at branch "cura5-refactored" and give it a try! tested it with cura 4.13 and cura 5.0 beta :)

cause of massive refactoring there could be some new bugs now ;)

@PhilBaz
Copy link

PhilBaz commented Apr 23, 2022

@emtrax-ltd Crash on open....

Screenshot 2022-04-22 182629

Traceback (most recent call last):
File "cura\CuraApplication.py", line 1109, in event
return super().event(event)
File "UM\Qt\QtApplication.py", line 489, in event
event._function_event.call()
File "UM\Event.py", line 218, in call
self._function(*self._args, **self._kwargs)
File "cura\Settings\MachineManager.py", line 179, in setInitialActiveMachine
self.setActiveMachine(active_machine_id)
File "cura\Settings\MachineManager.py", line 341, in setActiveMachine
self._application.setGlobalContainerStack(global_stack)
File "cura\CuraApplication.py", line 682, in setGlobalContainerStack
super().setGlobalContainerStack(stack)
File "UM\Application.py", line 283, in setGlobalContainerStack
self.globalContainerStackChanged.emit()
File "UM\Signal.py", line 216, in emit
self.__handleEmitIndirect(*args, **kwargs)
File "UM\Signal.py", line 323, in __handleEmitIndirect
self.__performEmit(*args, **kwargs)
File "UM\Signal.py", line 357, in __performEmit
func(dest, *args, **kwargs)
File "C:\Users\Philip\AppData\Roaming\cura\5.0\plugins\Cura2MoonrakerPlugin-cura5-refactored\Cura2MoonrakerPlugin-cura5-refactored\MoonrakerPlugin\MoonrakerPlugin.py", line 32, in _checkMoonrakerOutputDevice
config = getConfig()
File "C:\Users\Philip\AppData\Roaming\cura\5.0\plugins\Cura2MoonrakerPlugin-cura5-refactored\Cura2MoonrakerPlugin-cura5-refactored\MoonrakerPlugin\MoonrakerSettings.py", line 21, in getConfig
settings, printerId = _loadConfig()
File "C:\Users\Philip\AppData\Roaming\cura\5.0\plugins\Cura2MoonrakerPlugin-cura5-refactored\Cura2MoonrakerPlugin-cura5-refactored\MoonrakerPlugin\MoonrakerSettings.py", line 17, in loadConfig
settings = json.loads(preferences.getValue(MOONRAKER_SETTINGS))
File "json_init
.py", line 339, in loads
TypeError: the JSON object must be str, bytes or bytearray, not NoneType

@devolf92
Copy link
Author

devolf92 commented Apr 23, 2022

image
that what i got with refactored version after pressing upload button. but when i restarted app everything worked fine :D

emtrax-ltd added a commit that referenced this issue Apr 23, 2022
@emtrax-ltd
Copy link
Owner

image that what i got with refactored version after pressing upload button. but when i restarted app everything worked fine :D

in these cases please attach the cura.log

@PhilBaz
Copy link

PhilBaz commented Apr 23, 2022

With the updated version Cura now opens and I can get into the moonraker dialogue.....But 1) I cant enter an address, whatever I do it just doesn't hold a value. Double checking, nether dose API or name dialogue hold a value 2) I cant select the 'format' radio button to chose UFP.

Also, If I return to the settings menu--after interacting with the Moonraker dialogue--Cura crashes.

Screenshot 2022-04-23 082053

@devolf92
Copy link
Author

devolf92 commented Apr 23, 2022

pastebin or gdrive

second one link should work

emtrax-ltd added a commit that referenced this issue Apr 23, 2022
@emtrax-ltd
Copy link
Owner

done

hmmm.... Not Found (#404)

:(

@devolf92
Copy link
Author

gdrive my last hope :D i edited my previous post

@emtrax-ltd
Copy link
Owner

image that what i got with refactored version after pressing upload button. but when i restarted app everything worked fine :D

ok... i saw the log and this error only came up twice. All other times (then later) did the dialog work without problems?

@PhilBaz
Copy link

PhilBaz commented Apr 24, 2022

All good here after the last round....Seems to be working fine. Cura 5 to MainsailOS UFP with thumb.

Thank you very much!!!

emtrax-ltd added a commit that referenced this issue Apr 24, 2022
@emtrax-ltd
Copy link
Owner

branch merged...we need more "volunteers" now to find bugs ;)

@KoenVanduffel
Copy link

Tested the updated plugin in Cura 5.0, Win 10 works like a charm, ufp thumbnail is there. Only the power on of the printer I have not tested yet (configured it and nothing complains at least).

@emtrax-ltd
Copy link
Owner

next updates and new features in branch cura5-refactored-monitor

@PhilBaz
Copy link

PhilBaz commented Apr 29, 2022

Sweet...ill give er a go in the morning.

@PhilBaz
Copy link

PhilBaz commented Apr 29, 2022

@emtrax-ltd

Transfer with thumb is working fine... I see the new cam dialogue. What address does it want? Mine is plugged into the Pi running klipper. Not sure what the address is or how to find it. If you can give me a hint ill test it.

@KoenVanduffel
Copy link

I haven't tested the Webcam function yet but the url you can find in the settings dialog. Default is URL: /webcam/?action=snapshot

@PhilBaz
Copy link

PhilBaz commented Apr 29, 2022

using : /webcam/?action=snapshot or /webcam/?action=stream

The monitor dialogue doesn't show an image. I got the two URLs above from Mainsail OS.

But.... Im also pulling the image in Mainsail OS at the moment. So maybe that's the issue?

@KoenVanduffel
Copy link

KoenVanduffel commented Apr 29, 2022

I guess you have to prepend the url, or ip

Type the url direct in a browser, should work.

@PhilBaz
Copy link

PhilBaz commented Apr 29, 2022

Okay......got it!

http://xxx.xxx.x.xxx/webcam/?action=stream

@emtrax-ltd
Copy link
Owner

i will update the logic for webcam url in one of the next versions: absolute (http[s]://..) or relative (/....?..) urls will be supported!

@emtrax-ltd
Copy link
Owner

emtrax-ltd commented Apr 29, 2022

why "absolute" at this moment: because i dont have any webcams, so i only tested it with a free/private mjpeg-stream somewhere from the internet ;)

@PhilBaz
Copy link

PhilBaz commented Apr 29, 2022

Yeah, working great!!

Thank you for the excellent toys!!! I would say you should register the plugin with Cura market so more people can use this awesome app. But I imagine its a huge pain in the ass to jump through their hoops.

@emtrax-ltd
Copy link
Owner

The cura marketplace process is still ongoing -> their review step is very slow!

@emtrax-ltd
Copy link
Owner

hopefully that was the last fix for the branch cura5-refactored-monitor - if there are no more bugs, then i will merge this into main

@emtrax-ltd
Copy link
Owner

I think everything is done here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants