Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

bad bitmask on envelope direction #1

Closed
jwestfall69 opened this issue Jan 21, 2017 · 1 comment
Closed

bad bitmask on envelope direction #1

jwestfall69 opened this issue Jan 21, 2017 · 1 comment

Comments

@jwestfall69
Copy link
Contributor

impl Envelope {
...
    fn write_data_reg(&mut self, value: u8) {
        self.reg_data_reload = (value >> 4) as _;
        self.reg_data_direction = (value & 0x80) != 0; 
        self.reg_data_step_interval = (value & 0x07) as _;

The docs say the direction is the 4th bit, so the mask should be 0x08.

@yupferris
Copy link
Member

Haha oh man, I must be blind!! This is def the final piece of the puzzle. Thanks!

yupferris pushed a commit that referenced this issue Feb 11, 2017
Sinkstravaganza

Replaces `Color::add_color` with an `Add` impl.
Removes weird specialized sinks.
Pulls gamma correction out of the VIP and in to a sink so that the VIP output is in linear RGB space.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants