Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloak sensitive repository path strings #58

Closed
ProactiveServices opened this issue Jun 17, 2023 · 1 comment
Closed

Cloak sensitive repository path strings #58

ProactiveServices opened this issue Jun 17, 2023 · 1 comment

Comments

@ProactiveServices
Copy link

Some repository paths, such as REST servers with HTTP login details, contain passwords. Currently these are displayed in the "Path" of the "Open Repository" pane and the text box at the top of the main Restic Browser window. These strings should be cloaked in the same way the "Repository Password" field is.
nettnikl added a commit to nettnikl/restic-browser that referenced this issue Jul 13, 2023
@nettnikl
Hide passwords in repo path, fixing emuell#58
4d472e4
emuell pushed a commit that referenced this issue Jul 17, 2023
@nettnikl
Hide passwords in repo path, fixing #58 (#66)
b912990 
* Hide passwords in repo path, fixing #58
* Hide password length
* Improve regex handling of urls
@emuell
Copy link
Owner

emuell commented Jul 17, 2023

Password are now cloaked in the text box at the top of the main Restic Browser window, thanks to @nettnikl.
I personally think it's okay to display them in the "Open Repository" dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ProactiveServices @emuell