Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert NW.js 0.42.6 #250

Merged
merged 5 commits into from
Aug 21, 2020
Merged

revert NW.js 0.42.6 #250

merged 5 commits into from
Aug 21, 2020

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Jul 21, 2020 •
edited
Loading

  • revert to NW.js v0.42.6 dated 30-Nov-2019
  • fixes some variants of Windows CLI-tab buffer issue.
  • https://dl.nwjs.io/

@nerdCopter nerdCopter marked this pull request as ready for review July 31, 2020 15:29
@nerdCopter
Copy link
Member Author

nerdCopter commented Jul 31, 2020 •
edited
Loading

  • Seems to be the best solution :( barring any code re-write

@nerdCopter
Copy link
Member Author

nerdCopter commented Aug 21, 2020 •
edited
Loading

  • i did not submit PR, but i experimented with a windows vs other in the gulpfile.js and technically we can use latest NW.js on OSX/Linux and old version on Windows.... but i'm unsure how much effort to put into this since we will be starting over with Emu 1.0.0 Config

@nerdCopter nerdCopter merged commit 5fc9b70 into emuflight:master Aug 21, 2020
@nerdCopter nerdCopter mentioned this pull request Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quick-Flash Quick-Flash Quick-Flash approved these changes

@AndreySemjonov AndreySemjonov Awaiting requested review from AndreySemjonov

@loutwice loutwice Awaiting requested review from loutwice

Assignees
No one assigned
Labels
merge-able if approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nerdCopter @Quick-Flash