Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IRC Ghost serial protocol option #301

Merged
merged 4 commits into from
Dec 28, 2020
Merged

Add IRC Ghost serial protocol option #301

merged 4 commits into from
Dec 28, 2020

Conversation

Igorshp
Copy link
Contributor

@Igorshp Igorshp commented Dec 18, 2020

Add option to select Ghost protocol. #300

Depends on this emuflight/EmuFlight#443 PR.

@nerdCopter I'm bit confused how apiVersions work. What value should I use and where should it come from?

@nerdCopter nerdCopter marked this pull request as draft December 18, 2020 00:54
@nerdCopter
Copy link
Member

nerdCopter commented Dec 18, 2020 •
edited
Loading

  • right before release, we either add new MSP 1.50 (EEPROM) for semver. semver.gte(CONFIG.apiVersion, "1.50.0"), or
  • we'll have to semver on firmware release version. semver.gte(CONFIG.flightControllerVersion, "0.X.Y")

@nerdCopter
Copy link
Member

nerdCopter commented Dec 24, 2020 •
edited
Loading

we may end up going with
semver.gte(CONFIG.flightControllerVersion, "0.3.3") if we can get GHST merged soon @Igorshp

@nerdCopter
Add IRC Ghost serial protocol option
c962749 
* add based on firmware versions, since we not bumping MSP at this time
@nerdCopter
Merge branch 'master' into ghost-serial
363c263
@nerdCopter
Copy link
Member

  • based on >= 0.3.3 :
    2020-12-26_12-29
    2020-12-26_12-31

@nerdCopter
Add IRC Ghost serial protocol option
19681c0 
 Add IRC Ghost serial protocol option
c962749

* add based on MSP version
@nerdCopter nerdCopter marked this pull request as ready for review December 28, 2020 22:05
nerdCopter
nerdCopter approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions to EmuFlight!

@nerdCopter nerdCopter merged commit 5458e02 into emuflight:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees
No one assigned
Labels
want-in-next-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Igorshp @nerdCopter