Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSSI channel not being saved - old issue, still present #460

Open
szafranski opened this issue Jan 3, 2021 · 2 comments
Open

RSSI channel not being saved - old issue, still present #460

szafranski opened this issue Jan 3, 2021 · 2 comments

Comments

@szafranski
Copy link

szafranski commented Jan 3, 2021

Describe the bug
RSSI channel is not being saved (CLI and GUI - same thing).
There is some workaround (rssi_adc should be off in a first place), but it is not a proper fix I think.

To Reproduce
as in this video:
https://www.youtube.com/watch?v=x-qdaVpmn5o

Expected behavior
RSSI channel should be saved but it is not.

Additional context
It is old issue with a known workaround but it should not behave like this anyways - I think.

@Quick-Flash
Copy link
Member

yeah appears to be a gui bug rather than a firmware bug

@nerdCopter
Copy link
Member

i looked at the gui code for the old issue.

src/js/tabs/receiver.js line ~258 transfers the gui value into the variable RSSI_CONFIG.channel = parseInt($('select[name="rssi_channel"]').val());
then
line ~267 saves with MSP.send_message(MSPCodes.MSP_SET_RSSI_CONFIG, mspHelper.crunch(MSPCodes.MSP_SET_RSSI_CONFIG), false, save_rc_configs);

so i dont know why it fails to save.

i set a debug line for console.log, and the save executes properly irregardless of RSSI_ADC enabled or disabled.

my conclusion is that the gui performs as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants