Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Dependency injections flawless with Drupal? Can we separate styles? #57

Open
eeepam opened this issue Sep 9, 2022 · 2 comments
Open
Labels
🪄 Enhancement New feature or request.

Comments

@eeepam
Copy link

eeepam commented Sep 9, 2022

How this dependency injections works with Drupal?

I just installed and tested this system. Really awesome but I quite does not understand how naming works. When i install tabs molecules via emulsify cli it's grab well. But

{{ attach_library('emulsify/tabs') }}

This machine name is not converted automatically. So it's not match with my theme id which is my_awesome_theme (I just followed docs 😄)

So It's generates error.

image

I think we need some works on dependency system and replacing these dynamic machine names.

Because for now it's statically placed.

https://github.com/emulsify-ds/emulsify-drupal/blob/83bde70d36b8fe2c6074655e7fcee9366b6030f9/emulsify.libraries.yml#L19

To solve that problem we can use this kind hook and creates library for each atom/molecule etc.

https://www.drupal.org/project/drupal/issues/3092496

Part One: machine name tokenization to automatically update these names when grabbing these components to our newly created theme
Part Two: library dependency chain for all atoms/molecules etc. + webpack config for individually scss building + hook to load all libraries

@amazingrando amazingrando added the 🪄 Enhancement New feature or request. label Sep 9, 2022
@emircanerkul
Copy link

I have lots of progress regarding this improvement #61

Copy link

sync-by-unito bot commented Mar 26, 2024

➤ Callin Mullaney commented:

PR closed - #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪄 Enhancement New feature or request.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants