Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMLSIF-192: Read.me file to upgrade YML schema to use SDC #117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

EMLSIF-192: Read.me file to upgrade YML schema to use SDC #117

wants to merge 2 commits into from

Conversation

mariannuar
Copy link
Contributor

@mariannuar mariannuar commented May 17, 2024 •
edited
Loading

Summary

This PR implements the following features

  • Updates the Accordion component to give an example to convert components to support SDC
  • Adds documentation to convert components to support SDC

How to review this pull request

  • Run npm run storybook
  • Confirm all the components are working as expected, especially the Accordion one
  • Check the documentation makes sense

@mariannuar mariannuar added 🚧 Work in Progress The PR is a work in progress. 👍 Ready for Review Work is ready for review. and removed 🚧 Work in Progress The PR is a work in progress. labels May 17, 2024
@mariannuar mariannuar requested a review from josue2591 May 23, 2024 19:30
josue2591
josue2591 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@josue2591 josue2591 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clear an easy to follow, I only added a link to a resource as a suggestion

README.md Show resolved Hide resolved
@josue2591 josue2591 added 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Jun 6, 2024
@mariannuar @josue2591
Update README.md
35bb860 
Co-authored-by: josue2591 <josuegv2591@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josue2591 josue2591 josue2591 approved these changes

Assignees
No one assigned
Labels
🚫 On Hold 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer.
Projects
Emulsify Project
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mariannuar @josue2591