New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds tooltip component #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanhagerty This is great! I noticed a couple minor things that should probably be addressed before we approve and merge this.
- There is no
:focus
state on the tooltip when keyboard navigating. I realize this may be tricky, given how the button is only thei
element. Perhaps this needs to be refactored a bit to allow for proper focus states? - Also, the
.tooltip__content
is set todisplay: none
and I'm wondering if we should change this tovisibility: hidden
or something else that is more accessible? I don't think a lot of screen readers would read the tooltip content as it is right now.
Thanks for the review Joe. The tooltip had a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanhagerty This looks great! Thanks for making those changes.
🎉 This PR is included in version 1.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
This provides a tooltip component.
How to review this pull request
Screenshots