Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(93): replacing placeimg with Picsum #95

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

mndonx
Copy link
Contributor

@mndonx mndonx commented Jun 5, 2023

Summary

This PR fixes/implements the following bugs/features

  • Replaces PlaceIMG placeholder images with LoremFlickr images.

Explain the motivation for making this change. What existing problem does the pull request solve?

  • PlaceIMG is going away, this PR replaces placeholder images with Picsum images.

How to review this pull request

  • View storybook:
  • Image, Figure, Text with Media, Cards, Grid Cards, Article, Homepage (for some of these to work, you have to uncomment out some things in the Grid Cards stories and Twig files)
  • Ensure that they are all using Picsum instead.

Closing issues

Closes #93

@mndonx mndonx added the 👍 Ready for Review Work is ready for review. label Jun 5, 2023
Copy link

@Yuvania Yuvania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mndonx! This looks great, I can confirm that the replacement was successful

@Yuvania Yuvania added 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Jun 9, 2023
@mndonx mndonx marked this pull request as draft June 12, 2023 04:29
@mndonx
Copy link
Contributor Author

mndonx commented Jun 12, 2023

I might wanna wait on this to see if we should standardize on a service project-wide.

@mndonx
Copy link
Contributor Author

mndonx commented Jun 12, 2023

@Yuvania I ended up changing this from LoremFlickr to Picsum. I think that may be what we standardize on cross-projects. I also added something to imgsrcsets to make sure it was always pulling the same image (using an ID in the URL) so it didn't swap images when you cross breakpoints. Let me know if it still looks good to you! Thank you!!

@mndonx mndonx marked this pull request as ready for review June 12, 2023 18:00
@codeb-a
Copy link
Contributor

codeb-a commented Jun 16, 2023

Can confirm that the placeholder images are now all using Picsum. Looks good!

@mcortes19 mcortes19 marked this pull request as draft June 30, 2023 14:16
@mcortes19 mcortes19 marked this pull request as ready for review June 30, 2023 14:16
@mcortes19 mcortes19 changed the title fix(93): replacing placeimg with loremflickr fix(93): replacing placeimg with Picsum Jun 30, 2023
@mcortes19 mcortes19 merged commit e3fabc7 into main Jun 30, 2023
4 checks passed
@mcortes19 mcortes19 deleted the 93-replace-placeimg branch June 30, 2023 14:22
@github-actions
Copy link

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Replace PlaceIMG for image placeholders
4 participants