Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webpack-fix-style-only-entries #230

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add webpack-fix-style-only-entries #230

wants to merge 3 commits into from

Conversation

asipple1
Copy link

@asipple1 asipple1 commented Nov 10, 2021 •
edited by sync-by-unito bot
Loading

What:
Add webpack-fix-style-only-entries

Why:
Removes extra generated JS files from style-only entries. This cleans up the repo of unneeded styles.js files.

How to reproduce

  • Run: npm run develop on the main branch
  • Look at the dist folder for the extra css.js file that is not used.
  • Cancel npm run develop
  • Pull in this branch
  • Delete all contents in the dist folder
  • Rerun npm run develop

@ModulesUnraveled ModulesUnraveled added the 👍 Ready for Review Work is ready for review. label Nov 12, 2021
@amazingrando amazingrando added 👉 Needs Work Reviewer has requested changes. and removed 👍 Ready for Review Work is ready for review. labels Jul 15, 2022
@amazingrando
Copy link
Contributor

@asipple1 If you merge in the latest changes from master I will review this and get it into the repo. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-casias mark-casias mark-casias left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
👉 Needs Work Reviewer has requested changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asipple1 @amazingrando @mark-casias @ModulesUnraveled