refactor(accessibility testing): automates generation of story ids for accessiblity testing #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r accessiblity testing Updates a11y script to generate a list of stories and uses that list for accessibliity testing. Allows for ignoring stories in accessibility testing. emulsify-dsGH-151
|
Closing this PR, as the issue has been moved to Compound. A new PR will be created for that project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates a11y script to generate a list of stories and uses that list for accessibility testing.
Allows for ignoring stories in accessibility testing.
GH-151
What:
Removes the need to manually maintain a list of stories for accessibility testing. Allows projects to manually ignore specific stories in accessibility testing.
Why:
This change reduces cognitive load on developers as they no longer have to manually maintain the list of components to be tested for accessibility.
How:
Leverages Storybook's ability to provide a JSON object containing a project's stories (https://storybook.js.org/docs/react/sharing/storybook-composition#improve-your-storybook-composition).
h/t philwolstenholme for providing the script and documentation at (#151 (comment)).
To Test: