Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing icon property #2844

Closed
rosieks opened this issue May 6, 2022 · 3 comments · Fixed by #2895
Closed

Missing icon property #2844

rosieks opened this issue May 6, 2022 · 3 comments · Fixed by #2895
Assignees
@yushih
Labels
in-progress
Milestone
4.15.0

Comments

@rosieks
Copy link

rosieks commented May 6, 2022 •
edited
Loading

Current CIP-30 is missing icon property. According to specification there supposed to be window.cardano.yoroi.icon property with the link to icon so then we could use while connecting to wallet from dApp: https://github.com/cardano-foundation/CIPs/tree/master/CIP-0030#cardanowalletnameicon-string

image
@rosieks
Copy link
Author

rosieks commented May 10, 2022 •
edited
Loading

But why Cardano Support is going to look into issue of Yoroi wallet? Current implementation is missing property of CIP-30

@vsubhuman vsubhuman self-assigned this Jun 22, 2022
@vsubhuman vsubhuman added this to the 4.15.0 milestone Jun 22, 2022
@vsubhuman vsubhuman assigned yushih and unassigned vsubhuman Jun 22, 2022
@yushih
Copy link
Collaborator

yushih commented Jun 23, 2022

@rosieks thanks for reporting! What app is it in the screenshot? I've added the icon in #2895 and I'd like to test it.

@vsubhuman vsubhuman linked a pull request Jun 23, 2022 that will close this issue
add icon for connector API #2895
Merged
@vsubhuman
Copy link
Contributor

Will be available 4.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yushih yushih

Labels
in-progress
Projects
None yet
Milestone
4.15.0
Development

Successfully merging a pull request may close this issue.

add icon for connector API Emurgo/yoroi-frontend
4 participants
@yushih @rosieks @vsubhuman and others