Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaflet #123

Closed
wants to merge 46 commits into from
Closed

Leaflet #123

wants to merge 46 commits into from

Conversation

pedro-vicente
Copy link

This branch adds a Leaflet class
/src/leaflet

example

/examples/leaflet_test

demo

http://www.eden-earth.org:8081/

@emweb
Copy link
Collaborator

emweb commented Dec 13, 2017

I see a few problems with this PR:

  • It adds another Json parser to Wt, even though there is already a Json parser included in Wt.
  • It does not follow our conventions regarding directory structure and naming of files: headers in Wt 4 have a .h extension, and source files have a .C extension
  • It adds what appear to be utility classes into the src/Wt directory structure
  • The header file is not documented

I'm not too familiar with Leaflet, so I'm not sure what the added value would be, as far as I can tell it is not strictly necessary to merge it in Wt to use it?

Regards,
Roel

@pedro-vicente
Copy link
Author

Hi Roel

Leaflet
http://leafletjs.com/
is a "open-source JavaScript library for mobile-friendly interactive maps"

As opposed to Google Maps, it is free and open source, and probably one of the most used web map libraries.

so I'm not sure what the added value would be, as far as I can tell it is not strictly necessary to merge >>it in Wt to use it?

I am not sure if I understand what you're asking. The branch I developed allows for a Wt application
to use Leaflet in a ContainerWidget, in a almost exactly manner that you currently use Google Maps in Wt: some C++ code that calls the Javascript.

I developed it for my projects because I don't want to use Google Maps. So, I thought it could also be of general use for Wt. If you think it could add some value to Wt, we can work together to make the bullets you mention above "wt compliant".

If you don't think that it would be of general interest to Wt, we can leave at there :-)
Regards

@shiftee
Copy link

shiftee commented Dec 14, 2017

I for one would like to see this functionality integrated. I have wanted to provide an Openstreetmap alternative to the google map widget for some time now

@emweb
Copy link
Collaborator

emweb commented Apr 30, 2019

We're working on a WLeafletMap implementation for Wt now, so stay tuned. This PR can't be merged in its current state, though, so I'll close this.

Regards,
Roel

@emweb emweb closed this Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants