Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WStringStream to accept const char strings #135

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

zachstruck-ordis
Copy link
Contributor

Fix WStringStream to directly accept const char * strings.
Remove overly greedy template overload operator<<.
Remove string literal overload to reduce template bloat since there is now a const char * overload that can accept string literals.

@emweb
Copy link
Collaborator

emweb commented Jun 26, 2018

Now to comment on the correct PR:

That's indeed a bit of a silly optimization. I noticed that the compiler will just optimize the strlen call out if the implementation is in the header. I updated your PR with that little change.

Regards,
Roel

@emweb emweb merged commit 02e6b84 into emweb:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants