removed canary boost.system library after check #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about doing it scoped in a function? Do you notice any problems with that? scoped_find_boost_system.patch.txt Regards, |
emweb
pushed a commit
that referenced
this pull request
Jun 12, 2019
…d_package Alternative solution to PR #155
|
That last commit (42386ae) should fix it. If there's an issue anyway, feel free to comment. Regards, |
|
Looks like that should do the trick. It makes sure that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
find_package(Wt REQUIRED)method of depending on Wt, the boost.system library's absolute path from where Wt was compiled at was found to be a dependency.This was a result of the check added for optionally including the system component depending on the version of the Boost library. The check would set the
Boost_SYSTEM_LIBRARYto an absolute path, and on version 1.69 of the Boost library, that absolute path would not be transformed to the import target, but would leak into theBOOST_WT_LIBRARIESandBOOST_WTHTTP_LIBRARIESvariables.Clearing the
Boost_SYSTEM_LIBRARYvariable after the check, solves this problem, though all of the variables that the check sets should be cleared. That is difficult though.