Resolved an issue with DBO_EXTERN_TEMPLATES and DBO_INSTANTIATE_TEMPLATES #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you change your commit message to be more like the description of your pull request I can merge it. Now it's one long line broken by Regards, |
|
My intention was that you amend your commit and add the body of your PR as well, but I'll just go ahead and fix that for you 🙂 Regards, |
…ATES The Wt::Dbo::query_result_traits<> template was declared and defined as 'struct' in SqlTraits.h, but is declared as 'class' in the DBO_EXTERN_TEMPLATES and DBO_INSTANTIATE_TEMPLATES macros. This inconsistency causes multiple compiler warnings, such as C4099 on Visual Studio 2017/2019., whenever the macros are used. Declaring as struct solves the issue.
|
Sorry, misunderstood what you meant. Thanks for changing it :) Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wt::Dbo::query_result_traits<> template was declared and defined as 'struct' in SqlTraits.h, but is declared as 'class' in the DBO_EXTERN_TEMPLATES and DBO_INSTANTIATE_TEMPLATES macros. This inconsistency causes multiple compiler warnings, such as C4099 on Visual Studio 2017/2019., whenever the macros are used. Declaring as struct solves the issue.