Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRN-19694: Support for React18 #92

Merged
merged 6 commits into from
Apr 4, 2022
Merged

Conversation

MikyungKim
Copy link
Contributor

In this PR, we'd like to add support for React18.
React18 introduced createRoot and hydrateRoot instead of render and hydrate. And the exported pacakge changed from react-dom to react-dom/client.
The detailed information you could refer to is https://reactjs.org/blog/2022/03/29/react-v18.html.

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, LGTM

@hong6316 hong6316 merged commit 01f9a35 into feature/webpack5 Apr 4, 2022
@hong6316 hong6316 deleted the feature/react-18 branch April 4, 2022 06:14
hong6316 added a commit that referenced this pull request Apr 11, 2022
* WRN-18582: Migrate to webpack5 (#90)

* WRN-18582: webpack5 initial commit

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-18582: Migrated isomorphic and snapshot plugin

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update verbose plugin

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix travis errors

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update dependencies

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix based on review

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update shrinkwrap

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-12124: Remove deprecated babel-eslint module (#87)

* use @babel/eslint-parser

* remove babel-preset-react-app

* remove @babel/eslint-parser

* Revert "remove @babel/eslint-parser"

This reverts commit 98ec872.

* Revert "remove babel-preset-react-app"

This reverts commit 70a93e2.

* Revert "use @babel/eslint-parser"

This reverts commit 5c15b55.

* babel-eslint -> @babel/eslint-parser

* add CHANGELOG.md

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* update npm-shrinkwrap.json

* removed unused dependency

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update eslint-config-prettier

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* WRN-19252: Fix VerboseLogPlugin is not working (#91)

* WRN-19252: Use ProgressPlugin from originated place

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* pinned webpack version

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-12748: Update eslint 8 related modules (#88)

* update eslint 8

* Update package.json

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* WRN-19694: Support for React18 (#92)

* update react version

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update dependencies

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-19694: Add react18 support

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-20218: Fix eanct pack --framework and --externals options (#93)

* WRN-20218: Fix enact pack --framework

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix context

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix lint

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix local node_modules files and files ends with .js module id

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-20481: Fixed miss made module id and miss referenced library (#94)

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Fix prerendering regex

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update dependencies

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants