Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRO-9096: Update react-redux related documentation #3081

Merged
merged 26 commits into from Aug 23, 2022
Merged

WRO-9096: Update react-redux related documentation #3081

merged 26 commits into from Aug 23, 2022

Conversation

vladut-clapou-lgp
Copy link
Contributor

@vladut-clapou-lgp vladut-clapou-lgp commented Aug 9, 2022 •
edited by MikyungKim

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

The redux related documentation was outdated so it needed an update.

Resolution

Additional Considerations

Links

WRO-9096

Comments

Enact-DCO-1.0-Signed-off-by: Clapou Vladut vladut.clapou@lgepartner.com

@codecov
Copy link

codecov bot commented Aug 9, 2022 •
edited

Codecov Report

Merging #3081 (ef34ff8) into develop (c437b08) will not change coverage.
The diff coverage is n/a.

❗ Current head ef34ff8 differs from pull request most recent head f9af526. Consider uploading reports for the commit f9af526 to get more accurate results

@@           Coverage Diff            @@
##           develop    #3081   +/-   ##
========================================
  Coverage    48.26%   48.26%           
========================================
  Files          172      172           
  Lines         9730     9730           
  Branches      2615     2615           
========================================
  Hits          4696     4696           
  Misses        3951     3951           
  Partials      1083     1083

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

stanca-pop-lgp
stanca-pop-lgp approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrian-cocoara-lgp
Copy link
Contributor

Please update changelog

adrian-cocoara-lgp
adrian-cocoara-lgp approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikyungKim
Copy link
Contributor

Please rebase your branch with the latest develop branch.

MikyungKim
MikyungKim reviewed Aug 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@MikyungKim
update docs
cdc0f6b 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
fix
3b95d27 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
MikyungKim and others added 2 commits August 19, 2022 16:49
@MikyungKim
typo
e2fc96d 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@vladut-clapou-lgp
Review fixes
45c6c2c
@MikyungKim
fix indentation
22ef24d 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
vladut-clapou-lgp and others added 8 commits August 23, 2022 10:15
@vladut-clapou-lgp @MikyungKim
Update docs/redux/redux-intro.md
fa065cd 
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
@vladut-clapou-lgp
Review fix
8c6fcce
@vladut-clapou-lgp
Merge branch 'feature/WRO-9096' of https://github.com/enactjs/enact i…
c4e898c 
…nto feature/WRO-9096
@vladut-clapou-lgp
Review fix
3ab134e
@vladut-clapou-lgp
Review fix
58866b4
@MikyungKim
more fix
4701fd5 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
added a link
ef34ff8 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
revert the meaningless change
f9af526 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
MikyungKim
MikyungKim approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Great job @vladut-clapou-lgp!

@MikyungKim MikyungKim merged commit 0b7251c into develop Aug 23, 2022
@MikyungKim MikyungKim deleted the feature/WRO-9096 branch August 23, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-stoian-lgp daniel-stoian-lgp daniel-stoian-lgp left review comments

@MikyungKim MikyungKim MikyungKim approved these changes

@adrian-cocoara-lgp adrian-cocoara-lgp adrian-cocoara-lgp approved these changes

@stanca-pop-lgp stanca-pop-lgp stanca-pop-lgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vladut-clapou-lgp @adrian-cocoara-lgp @MikyungKim @daniel-stoian-lgp @stanca-pop-lgp