Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRN-5671: Samples: npm run test is not working #132

Merged
merged 10 commits into from Dec 22, 2021
Merged

Conversation

sjro
Copy link
Contributor

@sjro sjro commented Dec 14, 2021

Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)

  • Modify 'npm run test' and 'npm run test-watch' of each samples to work

Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)
@MikyungKim
Copy link
Contributor

As I mentioned in the ticket, let's add a test script for running all tests through the samples and fix errors when running tests.

Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)
Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)
Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)
Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)
Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)
Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)
Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)
 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com)
scripts/bootstrap.js Outdated Show resolved Hide resolved
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@MikyungKim MikyungKim merged commit 310d128 into develop Dec 22, 2021
@MikyungKim MikyungKim deleted the feature/WRN-5671 branch December 22, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants