Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-16694: Updated ui-tests to use expect from jest #1592

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Conversation

ion-andrusciac-lgp
Copy link
Contributor

@ion-andrusciac-lgp ion-andrusciac-lgp commented Apr 15, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Removed chai library dependency in ui-test-utils. This required some updates on all ui-tests

Resolution

  • Updated ui-tests to use expect from jest
  • Updated ui-test-utils to v1.0.8

Additional Considerations

Links

WRQ-16694

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (16e847c) to head (5ceb741).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1592   +/-   ##
========================================
  Coverage    81.55%   81.55%           
========================================
  Files          148      148           
  Lines         6674     6674           
  Branches      1986     1986           
========================================
  Hits          5443     5443           
  Misses         938      938           
  Partials       293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniel-stoian-lgp daniel-stoian-lgp changed the title WRQ-16694: Removed chai library dependency WRQ-16694: Updated ui-tests to use expect from jest Apr 18, 2024
@hong6316 hong6316 changed the base branch from develop to master May 16, 2024 08:31
@hong6316 hong6316 changed the base branch from master to develop May 16, 2024 08:31
Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hong6316 hong6316 merged commit 0e738c1 into develop Jun 11, 2024
7 checks passed
@hong6316 hong6316 deleted the feature/WRQ-16694 branch June 11, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants